Consider caching ConnectivityManager in GeckoAppShell.java
Categories
(Core :: Networking, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: valentin, Assigned: sonakshisaxena1)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
https://phabricator.services.mozilla.com/D51561#1594289
This can be somewhat slow, so if we plan to call this a lot we should consider caching the ConnectivityManager.
We have a bunch of methods that use the ConnectivityManager, so we may want to actually do that.
|
Assignee | |
Comment 1•5 years ago
|
||
(In reply to Valentin Gosu [:valentin] (he/him) from comment #0)
https://phabricator.services.mozilla.com/D51561#1594289
This can be somewhat slow, so if we plan to call this a lot we should consider caching the ConnectivityManager.
We have a bunch of methods that use the ConnectivityManager, so we may want to actually do that.
Hey [:valentin]
Would like to work on this. Can I take this too?
Thanks!
|
Reporter | |
Comment 2•5 years ago
|
||
Sure, you're welcome to work on it.
Make sure to set your Android env according to this: https://mozilla.github.io/geckoview/
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
Hey [:snorp]
Can you please review the patch?
Thanks!
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•