Stop supporting XUL [dir="reverse"] attribute value
Categories
(Toolkit :: XUL Widgets, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The XUL dir
attribute can be set to reverse
to set -moz-box-direction: reverse;
.
This attribute seems unused:
- https://searchfox.org/mozilla-central/search?q=dir%3D%22reverse%22&case=false®exp=false&path=
- https://searchfox.org/mozilla-central/search?q=%22dir%22%2C+%22reverse%22&case=false®exp=false&path=
Furthermore, this conflicts and causes confusion with the HTML dir
attribute which takes ltr
/auto
/rtl
as values.
Comment 1•5 years ago
|
||
Good idea, I was wondering about this while doing breakdown for stuff like Bug 1593023.
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=276421433&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/53c096b278f5888d8b7590786628b0634a80ed2f
[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - TEST-PASS | toolkit/content/tests/widgets/test_popupanchor.xhtml | arrow should not have moved: 182 should be equal(-ish) to 182
[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - Buffered messages finished
[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_popupanchor.xhtml | arrow should not have moved up or down: 47 should be equal(-ish) to 57
[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:277:18
[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - is_close@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_popupanchor.xhtml:23:5
[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - tests</</<@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_popupanchor.xhtml:302:19
[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - sub-test middle.veryTallPanel-start_after starting
[task 2019-11-15T13:27:03.025Z] 13:27:03 INFO - TEST-PASS | toolkit/content/tests/widgets/test_popupanchor.xhtml | height is what we requested.
Comment 5•5 years ago
|
||
Tim, I think you missed two instances of container.dir
being set in those two Custom Element implementations. The patch on autoland only seemed to change two instances but I see four in each file:
places-menupopup.js - https://searchfox.org/mozilla-central/search?q=container.dir&path=places-menupopup.js
panel.js - https://searchfox.org/mozilla-central/search?q=container.dir&path=panel.js
Assignee | ||
Comment 6•5 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #5)
Tim, I think you missed two instances of
container.dir
being set in those two Custom Element implementations. The patch on autoland only seemed to change two instances but I see four in each file:places-menupopup.js - https://searchfox.org/mozilla-central/search?q=container.dir&path=places-menupopup.js
panel.js - https://searchfox.org/mozilla-central/search?q=container.dir&path=panel.js
Good catch, thanks!
Comment 8•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Description
•