Closed Bug 1596454 Opened 5 years ago Closed 5 years ago

Enable browser_documentChannel.js with fission

Categories

(Core :: DOM: Navigation, task, P2)

task

Tracking

()

RESOLVED DUPLICATE of bug 1592894
Fission Milestone M4.1

People

(Reporter: u608768, Assigned: zombie)

References

(Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → ?
Fission Milestone: ? → M4.1
Flags: needinfo?(tomica)
Priority: -- → P3
Assignee: nobody → tomica
Flags: needinfo?(tomica)

Details from Kashav:

iirc, it's testing that we process switch correctly when we POST from a file uri
and that we process switch when we have browser.tabs.remote.useHTTPResponseProcessSelection enabled and don't when it's disabled
(the test_disabled is irrelevant when fission is enabled)

Depends on: 1598516

zombie, with the dependency DocumentChannel bug is now resolved, what's left to do for this to unblock Kashav for bug 1596217?

Flags: needinfo?(tomica)

Looking into.

Flags: needinfo?(tomica)

This doesn't seem to reproduce anymore, at least on Windows, both opt and debug with --verify.

On Linux, I'm still seeing the error, but the test no longer hangs. We skip (ignore?) 15 tests when Fission is enabled ("Ran 23 checks (22 subtests, 1 tests)" with Fission and "Ran 38 checks (37 subtests, 1 tests)" without Fission).

(also looks like the test was renamed to browser_documentChannel.js in bug 1592894 (https://phabricator.services.mozilla.com/D55793)).

(In reply to :kashav from comment #8)

We skip (ignore?) 15 tests when Fission is enabled

Details from Kashav:

(the test_disabled is irrelevant when fission is enabled)

Oops.

I still see the error message though, guess it was unrelated to the test (why would it have been hanging there?). Not sure if it's something we still need to fix.

The error message is unrelated and will be fixed in a different bug. Updating summary and component to reflect this.

No longer blocks: fission-webext
Component: General → DOM: Navigation
Product: WebExtensions → Core
Summary: [Fission] JavaScript error: resource://gre/modules/ExtensionCommon.jsm, line 415: SecurityError: Permission denied to access property "removeEventListener" on cross-origin object → Enable browser_documentChannel.js with fission

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Priority: P3 → --

The patch to unskip this test has landed in bug 1592894.

Status: NEW → RESOLVED
Closed: 5 years ago
Priority: -- → P2
Resolution: --- → DUPLICATE
Attachment #9115178 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: