Closed
Bug 1596506
Opened 5 years ago
Closed 5 years ago
Remove GetBindingParent usage from nsXULElement.
Categories
(Core :: DOM: Core & HTML, task)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files)
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
This is technically a behavior change, but the current thing is more correct
anyways, IMO, and it's only a warning in any case.
|
|
Assignee | |
Comment 2•5 years ago
|
||
We don't have any NAC which is a <xul:label>. We could keep it for shadow dom but it
doesn't seem to me like this code is working correctly.
nsXULLabelFrame::RegUnregAccessKey doesn't have similar code, and uses the
<label> node to register / unregister.
Finally, we do have non-anon labels, and those would be broken... So just
remove the special-case.
Depends on D53058
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c7c61985bf36
Remove GetBindingParent usage from nsXULElement::BindToTree. r=smaug
https://hg.mozilla.org/integration/autoland/rev/45374ab225da
Remove special-case for <xul:label> accesskey. r=smaug
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c7c61985bf36
https://hg.mozilla.org/mozilla-central/rev/45374ab225da
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•