Closed
Bug 1596572
Opened 5 years ago
Closed 5 years ago
make CompareStringInfinityOrNaN work with clang 5.x and C++17
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
clang 5.x (which is now our minimum supported clang version as of bug
1579189) doesn't quite work with inline variables and C++17.
Fortunately, we can make some straightforward changes to make the code
for CompareStringInfinityOrNan work in such situations.
|
||
Updated•5 years ago
|
Priority: -- → P1
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c468a5b5996
make CompareStringInfinityOrNaN work with clang 5.x and C++17; r=jandem
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•