Move OBJCOPY and STRIP detection to moz.configure
Categories
(Firefox Build System :: General, task)
Tracking
(firefox98 fixed)
Tracking | Status | |
---|---|---|
firefox98 | --- | fixed |
People
(Reporter: m_kato, Assigned: glandium)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(2 files, 1 obsolete file)
Since we use AC_CHECK_PROG to detect OBJCOPY and STRIP (for cross build and linux target), it doesn't work on Windows host. (Path has space etc)
Of course, when we use OBJCOPY=xxx in .mozconfig, it works well.
Reporter | ||
Comment 1•5 years ago
|
||
clang-cl sets PKG_SKIP_STRIP=1
, so STRIP='echo not_strip'
may be unnecessary.
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
As a bonus, we also check and prefer llvm-objcopy when it's suitable.
Assignee | ||
Comment 3•3 years ago
|
||
As a bonus, we also check and prefer llvm-strip when it's suitable.
Reporter | ||
Updated•3 years ago
|
Comment 5•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6c8f3c0aac51
https://hg.mozilla.org/mozilla-central/rev/da8f11880896
Comment 6•3 years ago
|
||
Backed out 2 changesets (Bug 1596656) for causing jittest failures on 1659595.js.
Backout link
Push with failures
Failure Log
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Comment hidden (obsolete) |
Updated•3 years ago
|
Assignee | ||
Comment 9•3 years ago
|
||
(In reply to Alexandru Ionescu (needinfo me) [:alexandrui] from comment #8)
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33094
This link sends to an alert on mozilla-beta...
Comment 10•3 years ago
|
||
Marked it as obsolete, thanks.
Comment 11•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b5cca3717e5a
https://hg.mozilla.org/mozilla-central/rev/0252bbc54dd1
Description
•