Closed Bug 1596724 Opened 5 years ago Closed 5 years ago

Print Preview toolbar glitch (some text and button overlaps)

Categories

(Toolkit :: Printing, defect, P1)

72 Branch
Desktop
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox-esr68 --- unaffected
firefox70 --- unaffected
firefox71 --- unaffected
firefox72 + fixed

People

(Reporter: alice0775, Assigned: bdahl)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(2 files, 1 obsolete file)

Attached image screenshot Nightly72 VS Beta71 (obsolete) (deleted) —

See attached screenshot

Has Regression Range: --- → yes
Has STR: --- → yes
User Story: (updated)
Regressed by: 1492582

[Tracking Requested - why for this release]: We can't ship this.

Component: Print Preview → Printing
Flags: needinfo?(bdahl)
Priority: -- → P1
Product: Core → Toolkit

There used to be a class called .numberbox-input that would apply to number input inside of the xbl bindings, and that was updated to use xul|*:root html|input[type="number"] in Bug 1437641 / https://hg.mozilla.org/mozilla-central/rev/00d33e7058c1#l31.46.

After Bug 1492582, we don't have a XUL root anymore. We could restore that class and set it in the print preview instance (and any other consumers that are inside of mox-box) then replace those XUL root selectors with the class instead: https://searchfox.org/mozilla-central/search?q=xul%7C*%3Aroot+html%7Cinput%5Btype%3D%22number%22%5D&path=.

The selectors that changed number inputs when they were used in a XUL
root document no longer make sense now that we're using an html root.
Convert the selector to a class instead. Also, add flex attribute so
the toolbar fills the whole width of the wrapping box.

My

Assignee: nobody → bdahl
Flags: needinfo?(bdahl)
Attached image screenshot Nightly72 VS Beta71 (deleted) —

And the right most background of toolbar is also regressed by Bug 1492582

Attachment #9108999 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
QA Whiteboard: [qa-72b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: