Closed Bug 1596843 Opened 5 years ago Closed 5 years ago

Remove some unused nsIPermissionManager APIs

Categories

(Core :: Permission Manager, defect)

Product:
Core
Component:
Permission Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(4 files)

Bug 1596843 - Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method;
(deleted), text/x-phabricator-request
Details
Bug 1596843 - Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes();
(deleted), text/x-phabricator-request
Details
Bug 1596843 - Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method;
(deleted), text/x-phabricator-request
Details
Bug 1596843 - Part 4: Remove some native only methods from nsIPermissionManager;
(deleted), text/x-phabricator-request
Details
No description provided.
Pushed by rgurzau@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b10aec041377 Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method; r=baku https://hg.mozilla.org/integration/autoland/rev/8b2220bc47af Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes(); r=baku https://hg.mozilla.org/integration/autoland/rev/a9827fae8655 Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method; r=baku https://hg.mozilla.org/integration/autoland/rev/69ee727d5b45 Part 4: Remove some native only methods from nsIPermissionManager; r=baku
Backout by rgurzau@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/de185bb7bdd5 Backed out 4 changesets for XPCShellTestsTests build bustage ona CLOSED TREE.

: Ehsan Hi, tried to land these changes to test them but got some failures and a backout was needed.

These are the failures:

  • XPCShellTestsTests::testChild TEST-UNEXPECTED-FAIL: TH link | Log link

  • Assertion failure at nsPermissionManager.cpp: Th link | Log link

  • application crashed [@ nsPermissionManager::SetPermissionsWithKey(nsTSubstring<char> const&, nsTArray<IPC::Permission>&)] TH link | Log link

Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88e8383dc3e4 Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method; r=baku https://hg.mozilla.org/integration/autoland/rev/691397c2fde6 Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes(); r=baku https://hg.mozilla.org/integration/autoland/rev/b9061f93d045 Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method; r=baku https://hg.mozilla.org/integration/autoland/rev/48577632f4b3 Part 4: Remove some native only methods from nsIPermissionManager; r=baku
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83096c9e152d Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method; r=baku https://hg.mozilla.org/integration/autoland/rev/70e1692d29f5 Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes(); r=baku https://hg.mozilla.org/integration/autoland/rev/21bfefb23045 Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method; r=baku https://hg.mozilla.org/integration/autoland/rev/03b7360a15dd Part 4: Remove some native only methods from nsIPermissionManager; r=baku
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: