This might depend on a change to switch away from the current array-in-a-pref whitelist implementation towards something that uses the permissions manager to store whitelist entries. Then we could re-use other similar prefs UIs.

This seems like something we should add enterprise policy for?

I think this is covered by the existing DNSoverHTTPS policy rules: https://github.com/mozilla/policy-templates/blob/master/README.md#dnsoverhttps

(In reply to Valentin Gosu [:valentin] (he/him) from comment #6)

I think this is covered by the existing DNSoverHTTPS policy rules: https://github.com/mozilla/policy-templates/blob/master/README.md#dnsoverhttps

You're totally right. Forgot we added that. Thanks for double checking!

Backed out for causing xpcshell failures in test_dooh.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-TIMEOUT | netwerk/test/unit/test_dooh.js | Test timed out

Do you want to add an Fx113 relnote for this (or maybe DoH UI improvements more generally)?

(In reply to Ryan VanderMeulen [:RyanVM] from comment #11)

Do you want to add an Fx113 relnote for this (or maybe DoH UI improvements more generally)?

Yes, I think we should.
Release notes would be something along the lines: Bug 1610741 moved the DNS over HTTPS settings to the Privacy & Security section of the settings page and allows the user to choose from all the supported modes. Bug 1596847 added UI to manage the DNS over HTTPS exception list.

Release Note Request (optional, but appreciated)
[Why is this notable]: Adds more advanced UI for controlling DoH settings to avoid having users set about:config prefs.
[Affects Firefox for Android]: No
[Suggested wording]:

Bug 1610741 moved the DNS over HTTPS settings to the Privacy & Security section of the settings page and allows the user to choose from all the supported modes. Bug 1596847 added UI to manage the DNS over HTTPS exception list.

[Links (documentation, blog post, etc)]: DoH UI Improvements project plan

https://hg.mozilla.org/mozilla-central/rev/7746c3a39e92

Backed out because of https://bugzilla.mozilla.org/show_bug.cgi?id=1610741#c12

https://hg.mozilla.org/mozilla-central/rev/29ad2fd4196f

Note added to Nightly 114 release notes in the NEW section with this wording:

Added UI to manage the DNS over HTTPS exception list.

Kershaw, could you explicitely request the uplift to beta in this bug? (this one is mentioned in bug 1610741 uplift request) Thanks

Comment on attachment 9324852 [details]
Bug 1596847 - DoH settings UI for excluded domains, r=valentin

(In reply to Valentin Gosu [:valentin] (he/him) from bug 1610741 comment #18)

Beta/Release Uplift Approval Request

• User impact if declined: Users will receive the DoH settings UI in Fx 114 instead of Fx 113
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: QA is in progress: https://mozilla-hub.atlassian.net/browse/QA-1817
• List of other uplifts needed: Bug 1596847, Bug 1826749
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): We have identified some edgecases in bug 1826749 and fixes are currently waiting for review; QA has identified bug 1825538 (proxies might not work when DoH strict mode is enabled). The main risks would be shipping the UI without these fixes. I think the risk of major bugs with the UI implementation is low.
• String changes made/needed: Yes. Strings in preferences.ftl, permissions.ftl were added.
• Is Android affected?: No

Comment on attachment 9324852 [details]
Bug 1596847 - DoH settings UI for excluded domains, r=valentin

Per discussion with the various stakeholders, this is going to ride the 114 train.