Fix padding for tip results
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox70 | --- | unaffected |
firefox71 | --- | unaffected |
firefox72 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Tip results don't have their intended padding. Looks like bug 1593959 regressed this.
Assignee | ||
Comment 1•5 years ago
|
||
Comment 2•5 years ago
|
||
it would be nice to have a script to run in the Browser Console, or an add-on, registering a provider that returns one result per type, when testing theme/alignment changes. Getting Tip results is a problem because there's no integrated provider doing it, nor an add-on one can easily install for testing purposes.
Comment 3•5 years ago
|
||
I've kept this patch floating around in my tree and rebase it on top of my work to test tip changes. I agree we should have something a bit easier to use though.
Assignee | ||
Comment 5•5 years ago
|
||
Is mozscreenshots still running? We could use that. Otherwise, in addition to the ideas mentioned here (an add-on, Harry's script), another manual testing possibility is to run one of the browser tests that creates a tip and stop it (e.g. add an await new Promise(r => {})
) when it's shown.
Assignee | ||
Comment 6•5 years ago
|
||
M(ss) are the screenshots tests, for example: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=998ab0bd0e35beee827d02f3fde27948c83c243f&searchStr=screenshot&selectedJob=277082397
Comment 7•5 years ago
|
||
bugherder |
Comment 8•5 years ago
|
||
(In reply to Harry Twyford [:harry] from comment #3)
we should have something a bit easier to use
Here's an add-on! https://github.com/htwyford/urlbar-results-tester
Updated•5 years ago
|
Updated•3 years ago
|
Description
•