Closed Bug 1597381 Opened 5 years ago Closed 5 years ago

Create profiler presets for about:profiling

Categories

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

enhancement

Tracking

(firefox74 fixed)

RESOLVED FIXED
Firefox 74
Tracking Status
firefox74 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

References

Details

Attachments

(3 files)

The new about:profiling page, and the new minimal profiler popup should support profiler presets. This bug is for the work to implement the minimal version of that. We will hard code certain presets that can be switched, and a "custom" preset, that will take the user to the about:profiling page.

Depends on: 1589681
Priority: -- → P2
Assignee: nobody → gtatum
Summary: Create profiler presets for the new minimal profiler popup → Create profiler presets for about:profiling

I'm tweaking this bug a bit, as I'll be implementing the presets in about:profiling only, and they will not be configurable. This will build out the infrastructure for the presets, but the UI in the minimal popup will be done in Bug 1597378.

This commit creates profiler presets for the current browser. It does not
handle remote profiling yet, as there is no UI surface for it yet. The
preset setting updates happen inside of the reducers and presets, and not
the selectors. This design was chosen so that as the presets were changed,
it would actually change the settings below, making it easy to change and
customize the settings by chosing the nearest preset.

The UI designs are still in a bit of a flux, so this UI design was the
easiest to implement for the initial pass, but we don't yet have consensus
on what the UI will look like for the final design.

Depends on D57120

This commit changes the testing utility to be generic to work for any
input radio or checkbox on the page, where the input is located near
in the DOM to the text element.

Depends on D58465

Depends on D58466

Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a56daa3b589f Create profiler presets for about:profiling; r=julienw https://hg.mozilla.org/integration/autoland/rev/42cb24ce9f4e Make testing util getNearestInputFromText generic; r=julienw https://hg.mozilla.org/integration/autoland/rev/c4eff4dc1e1f Add tests for the about:profiling presets; r=julienw
Regressions: 1611815
Regressions: 1623529
No longer depends on: 1589681
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: