Closed
Bug 1597414
Opened 5 years ago
Closed 5 years ago
Fix uses of mozilla::dom::ScreenOrientation::GetLockOrientationPermission in dom/base/ScreenOrientation.cpp
Categories
(Core :: DOM: Navigation, defect, P3)
Core
DOM: Navigation
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: djvj, Assigned: tetsuharu)
References
(Blocks 1 open bug)
Details
(Whiteboard: [rm-docshell-tree-item:simple])
Attachments
(2 files)
In file dom/base/ScreenOrientation.cpp
Checks ItemType on document of owner window for ScreenOrientation.
ScreenOrientation is associated with nsScreen which hangs off of window anyway, so window should be in-process.
Just change ItemType to use BrowsingContext variant instead of nsIDocShellTreeItem variant.
|
||
Comment 1•5 years ago
|
||
Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).
Fission Milestone: --- → M6
|
||
Updated•5 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
||
Updated•5 years ago
|
Attachment #9119964 -
Attachment description: Bug 1597414 - part 1: Fix uses of nsIDocShellTreeItem in mozilla::dom::ScreenOrientation::GetLockOrientationPermission. → Bug 1597414 - Fix uses of nsIDocShellTreeItem in mozilla::dom::ScreenOrientation::GetLockOrientationPermission.
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3884b282acc4
Fix uses of nsIDocShellTreeItem in mozilla::dom::ScreenOrientation::GetLockOrientationPermission. r=kmag
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in
before you can comment on or make changes to this bug.
Description
•