Closed
Bug 1597442
Opened 5 years ago
Closed 5 years ago
Fix uses of nsJSContext::MaybeRunNextCollectorSlice in dom/base/nsJSEnvironment.cpp
Categories
(Core :: DOM: Navigation, defect, P3)
Core
DOM: Navigation
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: djvj, Assigned: tetsuharu)
References
(Blocks 1 open bug)
Details
(Whiteboard: [rm-docshell-tree-item:simple])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In file dom/base/nsJSEnvironment.cpp
Uses DocShell tree to check if argument DocShell is the same-type root for its tree. Internals not used.
Change to using BrowsingContext.
|
||
Comment 1•5 years ago
|
||
Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).
Fission Milestone: --- → M6
|
||
Updated•5 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
|
||
Comment 3•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tetsuharu, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(tetsuharu.ohzeki)
|
|
Assignee | |
Comment 4•5 years ago
|
||
Olli, May I land this?
I heard that your work might make this patch unnecessary.
Flags: needinfo?(tetsuharu.ohzeki) → needinfo?(bugs)
|
|
Assignee | |
Comment 6•5 years ago
|
||
Aha, thank you!
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f066f0e696e3
Remove the usage of nsIDocShellTreeItem from nsJSContext::MaybeRunNextCollectorSlice(). r=smaug
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•