Closed
Bug 1597449
Opened 5 years ago
Closed 5 years ago
Fix uses of mozilla::dom::BrowserChild::RecvSetWindowName in dom/ipc/BrowserChild.cpp
Categories
(Core :: DOM: Navigation, defect, P3)
Core
DOM: Navigation
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: djvj, Assigned: tetsuharu)
References
(Blocks 1 open bug)
Details
(Whiteboard: [rm-docshell-tree-item:simple])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In file dom/ipc/BrowserChild.cpp
Only usage is to QueryInterface WebNavigation into a DocShellTreeItem, and then call SetName on it.
Implementation of SetName already forwards to mBrowsingContext.
Change to get the mBrowsingContext directly off of WebNavigation and update there.
Only implementors of nsIWebNavigation are nsDocShell and nsWebBrowser anyway.
|
||
Comment 1•5 years ago
|
||
Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).
Fission Milestone: --- → M6
|
||
Updated•5 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
|
|
||
Updated•5 years ago
|
Attachment #9123775 -
Attachment description: Bug 1597449 - Fix uses nsIDocShellTreeItem of mozilla::dom::BrowserChild::RecvSetWindowName(). → Bug 1597449 - Remove mozilla::dom::BrowserChild::Send/RecvSetWindowName() to remove usages of nsIDocShellTreeItem.
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ef53e2f57eeb
Remove mozilla::dom::BrowserChild::Send/RecvSetWindowName() to remove usages of nsIDocShellTreeItem. r=kmag
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•