Fix uses of nsResizerFrame::GetContentToResize in layout/xul/nsResizerFrame.cpp
Categories
(Core :: DOM: Navigation, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: djvj, Assigned: tetsuharu)
References
(Blocks 1 open bug)
Details
(Whiteboard: [rm-docshell-tree-item:simple])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
In file layout/xul/nsResizerFrame.cpp
Obtains DocShell from PresContext, and checks its ItemType.
Change to use BrowsingContex ItemType.
Comment 1•5 years ago
|
||
Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Backed out changeset 7da82c2eea17 (bug 1597488) for chrome failures at layout/xul/test/test_resizer.xhtml
Backout: https://hg.mozilla.org/integration/autoland/rev/fdb7d4f7cacb1c22a97b59734d7fcd1fdf12c802
Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7da82c2eea17d0bef54e5db27f822174ccdb05c9
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283353630&repo=autoland&lineNumber=30102
[task 2020-01-03T14:39:30.984Z] 14:39:30 INFO - TEST-PASS | layout/xul/test/test_resizer.xhtml | Bad y for -1,-1 moving -1,-1
[task 2020-01-03T14:39:30.984Z] 14:39:30 INFO - Buffered messages finished
[task 2020-01-03T14:39:30.984Z] 14:39:30 INFO - TEST-UNEXPECTED-FAIL | layout/xul/test/test_resizer.xhtml | Bad width for -1,-1 moving -1,-1 - got 300, expected 305
[task 2020-01-03T14:39:30.984Z] 14:39:30 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:325:16
[task 2020-01-03T14:39:30.984Z] 14:39:30 INFO - testResizer@chrome://mochitests/content/chrome/layout/xul/test/window_resizer.xhtml:53:11
[task 2020-01-03T14:39:30.984Z] 14:39:30 INFO - doTest@chrome://mochitests/content/chrome/layout/xul/test/window_resizer.xhtml:66:14
[task 2020-01-03T14:39:30.984Z] 14:39:30 INFO - setTimeout handler*onload@chrome://mochitests/content/chrome/layout/xul/test/window_resizer.xhtml:1:11
[task 2020-01-03T14:39:30.984Z] 14:39:30 INFO - Not taking screenshot here: see the one that was previously logged
Assignee | ||
Comment 5•5 years ago
|
||
(In reply to Cristina Coroiu [:ccoroiu] from comment #4)
Backed out changeset 7da82c2eea17 (bug 1597488) for chrome failures at layout/xul/test/test_resizer.xhtml
Ugh, I pushed some patch patterns to try, the patch which uses BrowsingContext would not be a problem...
Assignee | ||
Comment 6•5 years ago
|
||
I’m embarrassed. I forget to invert the boolean value after changing the code.
https://phabricator.services.mozilla.com/D58483
Comment 8•5 years ago
|
||
bugherder |
Description
•