Open Bug 1597512 Opened 5 years ago Updated 2 years ago

Consider removing PrimaryContentShell

Categories

(Core :: DOM: Navigation, defect, P3)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Project Flags:
Fission Milestone Future

People

(Reporter: djvj, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:rename])

In file xpfe/appshell/AppWindow.cpp

Just returns the mPrimaryContentShell field from the object.

This should change to GetPrimaryBrowsingContext, returning a BrowsingContext. It should be in-process, as this seems to be chrome-only code (assert).

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3

This field is already somewhat broken by e10s, as the parent process was no longer able to observe which content shell is the primary one. I'm not certain if it is still used frequently by the content process, but we may want to consider removing it alltogether if it's functionality is completely useless for us.

I'm going to dupe a number of nsIDocShellTreeItem removal bugs related to the primary content shell onto this bug to reduce the number of bugs which we need to keep in flight. If we end up needing to handle each of these callers individually, we can split them back out again.

:mconley has suggested that frontend JS has generally moved on from using this field.

Blocks: rmrf-docshell-tree-item
No longer blocks: rm-docshell-tree-item
Fission Milestone: M6 → Future
Summary: Fix uses of mozilla::AppWindow::GetPrimaryContentShell in xpfe/appshell/AppWindow.cpp → Consider removing PrimaryContentShell
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.