Closed
Bug 1597739
Opened 5 years ago
Closed 5 years ago
mingw builds don't define ASSOCF_NONE (and presumably other API flags for AssocQueryString?)
Categories
(Firefox Build System :: General: Unsupported Platforms, defect)
Firefox Build System
General: Unsupported Platforms
Tracking
(firefox73 fixed)
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: Gijs, Assigned: tjr)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
See: https://docs.microsoft.com/en-us/windows/win32/shell/assocf_str
https://docs.microsoft.com/en-us/windows/win32/api/shlwapi/nf-shlwapi-assocquerystringa
Failure that occurred without a backup define:
https://bugzilla.mozilla.org/show_bug.cgi?id=1263176#c13
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276892851&repo=autoland&lineNumber=60167
It'd be nice to update the toolchain so we can remove the mingw ifdef.
|
Assignee | |
Updated•5 years ago
|
Blocks: mingw-clang
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → tom
Pushed by tritter@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eaaa6098d18f
Remove MinGW define for ASSOCF_NONE r=Gijs
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•