Closed Bug 1597755 Opened 5 years ago Closed 5 years ago

[Interventions] Make query matching less aggressive by not using the mean edit distance

Categories

(Firefox :: Address Bar, task, P1)

task
Points:
2

Tracking

()

RESOLVED FIXED
Iteration:
72.3 - Nov 18 - Dec 1

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(1 file)

I was talking with Marco yesterday about the possibility of the user's triggering multiple interventions as they type a query string. The example I gave is that when I type "firefox cres", we show the update intervention. Then when I type a final "h", we show the refresh intervention. It's a little surprising that we show the update intervention for "firefox cres". "cres" is an edit distance of 2 away from "free", which is an update keyword. So the total edit distance of "firefox cres" is 2, and divided by the word count (2), the final mean distance is 1, and that's why we show it.

I think we should tighten this up by requiring each word in the query string to have <= 1 distance, instead of the final mean distance <= 1.

Comment on attachment 9110067 [details] Link to GitHub pull-request: https://github.com/0c0w3/urlbar-search-interventions-experiment/pull/2 The PR linker automatically created this attachment, but it didn't flag you for anything. We can't flag for reviews on bugzilla anymore, so I'm not sure what it would flag anyway. So let's set the feedback flag instead?
Attachment #9110067 - Flags: feedback?(mak)
Comment on attachment 9110067 [details] Link to GitHub pull-request: https://github.com/0c0w3/urlbar-search-interventions-experiment/pull/2 I saw the request in gmail, so my mail filters work, I'm just lagging a bit behind on reviews. Looking into it. Feedback or needinfo may be nice anyway, if the linker could set a ni?... but I guess it's hard to couple bugzilla accounts to github accounts.
Attachment #9110067 - Flags: feedback?(mak)

It would definitely be nice if the linker automatically flagged for feedback or NI. Maybe we can talk to Peter about that, but I bet you're right that it's not easy.

I merged the PR, so I'll close this.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: