The fix for bug 61893 requires that the enctype text/plain be used in order for the form to be passed to the mail client. We should support others (at least url-encoded -- the default) ala NS4.x Apparently IE requires text/plain and most tutorials recommend it (because it is human readable) but there may be some people using NS4 who don't want to have to rewrite their pages. (think internal IS departments and intranets) Looking at the code it should be a relativly simple fix to just add url-encoded encoding to the list we check for, but there may be issues with keeping the path open for other encodings down the line. Note also that there is a request to attach files at some point through "file" input elements which would entail the acceptance of multipart-form-encoded That is bug 135980

the patch adds the desired functionality and moves some code to a local function to avoid code duplication.

Comment on attachment 93371 [details] [diff] [review] fix for the bug (actually enhancement) 1. Make HandleSubject static to avoid polluting the linker namespace, and change the name to something like CreateMailtoSubject or HandleMailtoSubject. 2. hasSubject, hasParams, paramSep no longer need to be declared down where you removed the stuff you put into HandleSubject.

added jkeiser's requirements

Comment on attachment 93375 [details] [diff] [review] improved fix r=jkeiser

Comment on attachment 93375 [details] [diff] [review] improved fix > +HandleMailtoSubject(nsCAutoString& aPath) { Make that take a nsCString& (which is not as specific) and sr=bzbarsky

improved patch

Comment on attachment 93605 [details] [diff] [review] replaced autostring with string trnsferring review flags

Comment on attachment 93605 [details] [diff] [review] replaced autostring with string a=asa (on behalf of drivers) for checkin to 1.1

fixed on trunk

verifying build 2002-08-05-08-trunk