Closed Bug 1597898 Opened 5 years ago Closed 4 years ago

Use RKV safe mode for kvstore

Categories

(Toolkit :: Storage, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: vporof, Assigned: vporof)

References

(Blocks 4 open bugs)

Details

Attachments

(3 files)

Since kvstore is an RKV wrapper, and RKV is not supposed to be enabled in release when using an LMDB backend, about:support and MediaCapabilities performance benchmarks should use kvstore with safe mode enabled instead.

This bug is a merge of bug 1596012 and bug 1596051, since a single fix applies to both.

Blocks: ship-rkv
Type: task → enhancement
Priority: -- → P2

Depends on D54279

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:vporof, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(vporof)

Landing soon.
Update: this was deprioritized after the reorg, shelved.

Flags: needinfo?(vporof)
No longer blocks: rkv-perf-mode
No longer blocks: ship-rkv

I am now picking back up the work here.

Any update on this? :)

On it and hope to land asap before the soft freeze. Thanks for the ping!

Blocks: 1637680

Automatic migration between backends now landed in RKV and pushed to crates.io.
Just rebased the patches and doing one last try run before landing.

Pushed by vporof@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ac992b048e32 Part 1: Update RKV dependency to safe-mode, r=nanj https://hg.mozilla.org/integration/autoland/rev/3cfb899ae94c Part 2: Vendor newly added rust dependencies, r=nanj https://hg.mozilla.org/integration/autoland/rev/5159ffa5705c Part 3: Update kvstore to use RKV in safe mode, r=nanj
Pushed by vporof@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56c0d0013fda Part 1: Update RKV dependency to safe-mode, r=nanj https://hg.mozilla.org/integration/autoland/rev/ef1582f630a5 Part 2: Vendor newly added rust dependencies, r=nanj https://hg.mozilla.org/integration/autoland/rev/4e651edaacde Part 3: Update kvstore to use RKV in safe mode, r=nanj
Flags: needinfo?(vporof)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: