Closed
Bug 1598107
Opened 5 years ago
Closed 5 years ago
onResultPicked needs to indicate it's handling user input
Categories
(Firefox :: Address Bar, task, P1)
Firefox
Address Bar
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We added requireUserInput to some of the experiment APIs we're working on. These APIs will be called by the interventions extension in its onResultPicked listener. When I test my WIP extension, I get an error: "may only be called from a user input handler". We need to indicate that onResultPicked is fired as the result of user input. Fortunately it's easy: We just need to pass inputHandling=true to new EventManager.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4126c23bb67c
Set inputHandling=true for the browser.urlbar.onResultPicked event r=mak,mixedpuppy
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52b260c76e56
Backed out changeset 4126c23bb67c for causing browser chrome failures on browser_bug399606.js. CLOSED TREE
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8acdcbadf0e2
Set inputHandling=true for the browser.urlbar.onResultPicked event r=mak,mixedpuppy
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in
before you can comment on or make changes to this bug.
Description
•