[Wayland] Don't use GL_TEXTURE_EXTERNAL_OES textures with dmabuf backend
Categories
(Core :: Graphics, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
According to https://gitlab.freedesktop.org/mesa/mesa/issues/2119 we should remove GL_TEXTURE_EXTERNAL_OES and use just plain GL_TEXTURE_2D.
Assignee | ||
Comment 1•5 years ago
|
||
There's a WIP patch for it but I still have Webrender with external texture, I wonder if I need also update some rust code for it.
Assignee | ||
Comment 2•5 years ago
|
||
Sotaro, do you know how WebRender get texture target for shaders? I'm unable to persuade it to use TEXTURE_2D as it still uses TEXTURE_EXTERNAL. May it be due to EGLImage used here?
Thanks.
Comment 3•5 years ago
|
||
(In reply to Martin Stránský [:stransky] from comment #2)
Sotaro, do you know how WebRender get texture target for shaders? I'm unable to persuade it to use TEXTURE_2D as it still uses TEXTURE_EXTERNAL. May it be due to EGLImage used here?
WaylandDMABUFTextureHostOGL::PushResourceUpdates() set texture target type of WebRender as wr::TextureTarget::External. Changing it seems to affect to final OpenGL texture target type.
https://searchfox.org/mozilla-central/rev/0678172d5b5c681061b904c776b668489e3355b0/gfx/layers/opengl/WaylandDMABUFTextureHostOGL.cpp#111
The gl target type is selected at get_gl_target()
https://searchfox.org/mozilla-central/rev/0678172d5b5c681061b904c776b668489e3355b0/gfx/wr/webrender/src/device/gl.rs#179
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 6•5 years ago
|
||
bugherder |
Description
•