Fix some issues with improveTypesAtTest
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(3 files)
anba noticed the IonBuilder changes broke his optimization in https://phabricator.services.mozilla.com/D53174
The problem is that we no longer call improveTypesAtTest in some cases. Fortunately we can fix that pretty easily.
|
Assignee | |
Comment 1•5 years ago
|
||
createFallthroughJoinBlock was necessary at some point, but it no longer is
because we know before the loop whether we have incoming edges.
|
|
Assignee | |
Comment 2•5 years ago
|
||
When an MTest instruction results in a triangle structure, we now create an
empty block (like we did before bug 1595476) to get a diamond structure.
We did this for short-circuit operators but not for other cases.
We now also call improveTypesForTest for this block.
Depends on D54534
|
|
Assignee | |
Comment 3•5 years ago
|
||
I think this has been effectively dead code for a few years because we no longer
create the triangle structure for JSOP_AND and JSOP_OR.
Depends on D54535
|
||
Updated•5 years ago
|
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/95a4904b7465
https://hg.mozilla.org/mozilla-central/rev/2c25a18171ba
https://hg.mozilla.org/mozilla-central/rev/3d8cfd4a935d
Description
•