Closed
Bug 1599175
Opened 5 years ago
Closed 5 years ago
Remove unused 'browingContextId' message field in PictureInPictureChild.jsm
Categories
(Toolkit :: Video/Audio Controls, task, P3)
Toolkit
Video/Audio Controls
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(2 files)
I came across a typo in the name of a function where it said "BrowingContext", so I decided to check if there were any others. Low and behold, it turns out there is a similar typo in actual code in PictureInPictureChild.jsm:
browingContextId: this.docShell.browsingContext.id,
I was wondering why this hadn't been noticed before, but it appears that this field is just never used (and it looks like it was never used), so presumably it is some field that was being used an some intermediate state of the patch before it landed.
|
Assignee | |
Comment 1•5 years ago
|
||
This field is misspelled. Don't worry though, it is also unused.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82c3f78e59dd
part 1 - Remove unused 'browingContextId' message field in PictureInPictureChild. r=mconley
https://hg.mozilla.org/integration/autoland/rev/7edbb6ec9d6d
part 2 - Remove DOS line endings in PiP's browser.ini. r=mconley
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/82c3f78e59dd
https://hg.mozilla.org/mozilla-central/rev/7edbb6ec9d6d
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•