Closed
Bug 1599470
Opened 5 years ago
Closed 5 years ago
NullPrincipalURI::Init should not exist
Categories
(Core :: Security: CAPS, task)
Core
Security: CAPS
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: mccr8)
References
Details
Attachments
(2 files)
After bug 1346759 this function never fails, which means it should just move into the NullPrincipalURI constructor. That will make it much clearer at upstream callers which things can fail and which things can't. For example, it will make it clear that NullPrincipalURI::Create never returns null (and we could perhaps get rid of that method altogether, and use new NullPrincipalURI directly at the callsites).
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → continuation
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ee0f7ed68bb
part 1 - Inline the infallible NullPrincipalURI::Init. r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/05b73b0bbac2
part 2 - Inline the now-infallible NullPrincipalURI::Create(). r=bzbarsky
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8ee0f7ed68bb
https://hg.mozilla.org/mozilla-central/rev/05b73b0bbac2
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•