Closed Bug 1599510 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 20453 - [css-pseudo] Fix assert failure when combining ::first-line and ::marker

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Product:
Core
Component:
Layout: Generated Content, Lists, and Counters
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20453 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20453
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-pseudo] Fix assert failure when combining ::first-line and ::marker

The interaction of a ::marker pseudo-element with a 'content' property
and the ::first-line of the list-item produced a DCHECK failure in debug
builds (it was fine with debug disabled). This patch fixes it.

Bug: 457718

TEST=external/wpt/css/css-pseudo/first-line-and-marker.html

Change-Id: I443934f3a5cbfd95913287ac2bfb0966fa707e3d
Reviewed-on: https://chromium-review.googlesource.com/1937068
WPT-Export-Revision: f7a7e7aa6e636620fe39333b42d97ab27555dd2c

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/35d7a966ea8a [wpt PR 20453] - [css-pseudo] Fix assert failure when combining ::first-line and ::marker, a=testonly

https://hg.mozilla.org/mozilla-central/rev/35d7a966ea8a

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.