Closed
Bug 1599529
Opened 5 years ago
Closed 5 years ago
PictureInPicture keyboard shortcut code uses message manager instead of JSWindowActors
Categories
(Toolkit :: Video/Audio Controls, defect, P1)
Toolkit
Video/Audio Controls
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox71 | --- | unaffected |
| firefox72 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
I missed this during my review of bug 1576915, and we don't have any automated tests for the keyboard shortcut.
In this bug, I plan to:
- Write a patch to use JSWindowActors to send the keyboard toggle message
- Write a regression test for the keyboard shortcut so we don't get caught by surprise like this again
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D54786
|
||
Updated•5 years ago
|
Keywords: regression
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09d332954dd7
Use JSWindowActor message for Picture-in-Picture keyboard shortcut, and enable shortcut for Linux GTK. r=mstriemer
https://hg.mozilla.org/integration/autoland/rev/db6caab1c2bf
Add a test for the Picture-in-Picture keyboard shortcut. r=mstriemer
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/09d332954dd7
https://hg.mozilla.org/mozilla-central/rev/db6caab1c2bf
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
|
||
Updated•5 years ago
|
status-firefox71:
--- → unaffected
status-firefox-esr68:
--- → unaffected
|
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•