Localize about:profiling
Categories
(DevTools :: Performance Tools (Profiler/Timeline), task, P2)
Tracking
(firefox86 fixed)
Tracking | Status | |
---|---|---|
firefox86 | --- | fixed |
People
(Reporter: gregtatum, Assigned: gregtatum)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
We should localize about:profiling after the interface stabilizes a bit, that way we don't have to worry about changing localization strings until we are ready.
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
I have patches for this which I've attached, but need to spend more time on it before it's ready for review. It's also not handling the CustomizableUI side of it yet.
Assignee | ||
Comment 3•5 years ago
|
||
Note for the future on implementing localization for the popup
Add popup strings here: https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/appmenu.ftl
Search for data-l10n-id
for examples of usage.
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
This was based off of the differential revision:
https://phabricator.services.mozilla.com/D71403
I started a new revision as the old one had bitrotted quite a bit. I
handled flod's review feedback from the previous review.
This patch will require a follow-up with handling the profiler presets.
See Bug 1681539.
Assignee | ||
Comment 5•4 years ago
|
||
This handles most of the localization, but will require a few follow-ups.
First off is Bug 1681539, which is for localizing profiler presets. There
isn't anything too weird about this for the DevTools and about:profilling
context, but requires a solution for the popup. The appmenu.ftl bundle
might need to be included.
I did not localize profiler feature list, nor the byte size computation.
Depends on D99274
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
Comment 8•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c84e2486b321
https://hg.mozilla.org/mozilla-central/rev/589ce4061beb
Updated•3 years ago
|
Updated•3 years ago
|
Description
•