Using commercial branch 20020729 on all platforms. Also in the trunk builds. Thanks to Stephen for finding the bug. If you download a news mesg, go offline, and try to save the news mesg as a file or template you instead get this error mesg: 'unable to save the message.Please check your file name and try again later.' No problems with saving downloaded mail mesgs (imap/pop) while offline. No problems saving news mesgs while online. This bug has been here for a while. Used the 5-1 trunk build on mac 9.2 and I still see the problem. Steps: 1.subscribe to a newsgroup 2.Download the newsgroup 3.Go offline 4.Select a news mesg 5. Do a 'Save as' via file menu, context menu 6. Save as file or template results: get the error mesg unable to save expected: mesg to be saved and no error mesg

yup, this is pretty much the same as all the other bugs about what you can't do with downloaded news msg bodies while offline (like view source or save attachment)

Oh ok. Thought the problem was with nsMessenger.cpp but when I looked through the code, nothing sticks out. Adding for reference: bug 108107 - can't save news attachments while offline bug 128297 - can't view source of a news mesg while offline dang sorry i missed this.

Basically, I've taken the imap save as listener code and moved it into the mailnewsurl file (hence all the lines removed from nsImapService.cpp and all the lines added to nsMsgMailNewsUrl.cpp - they're the same) - then, I've added an interface on nsIMsgMailNewsUrl to get a save listener for a given url. I figure the url has a pretty good idea of what needs to happen for save as, if we need to specialize it later. The imap service now calls this method to get a listener. I've changed the news save as code to use this new listener method, and removed the old save as code for news. Using the listener in news fixes it for saving while offline. I've tested save as for news, and copying news message to an imap folder and it seems to work fine. This could probably be extended to the nsMailbox code but that code was a little bit scary.

Navin, can you review? The alternative to fixing it this way was just to duplicate all the imap save as listener code, but I didn't like duplicating all that code.

Will mozilla hdrs be the same for imap and news ? I don't know that is why I am asking.

you mean the mozilla status hdrs? Yes, they should be the same.

Comment on attachment 94409 [details] [diff] [review] proposed fix r=naving. Can you log a bug to use this for nsMailbox?

I'm not sure it's the right thing to do - for example, now that I look at it more closely, we don't need to do the envelope or mozilla status lines when saving a local msg, since the source already has those...

Comment on attachment 94409 [details] [diff] [review] proposed fix Some initial comments, still reviewing the code: PL_strstr(start, "\n"); wouldn't PL_strchr(start, '\n') be better? better yet, strchr() and strncmp() [still need PL_strncasecmp, curse the mac].

yes, sure - like I said, I just moved this code over from imap to base, as is, so I didn't look too closely at it. I'm sure it can be cleaned up some.

right, now I see you are just moving existing (and well tested) code around. reviewing now...

Comment on attachment 94409 [details] [diff] [review] proposed fix sr=sspitzer any cleanup of existing code you do is gravy.

fix checked in. Gary, could you make sure this works OK on Linux and Mac as well? thx.

Using commercial trunk 2002-09-19-08-trunk/ NT 4.0 2002-09-20-08-trunk/ Mac 10.1.5, mac 9.2.2 2002-09-20-08-trunk/ linux 2.2, red hat 7.0 With a downloaded news mesg, while offline, I can save a news mesg as a file with no problem via File menu or context menu. I can't test save as template due to bug 169990. When that's fixed, i can mark this as verified.

I'm going to go ahead and verify this, without waiting for bug 169990. I'll put a note in that bug for me to test Offline when that bug is fixed, as well. Verified FIXED with build 2002-10-03-08, Windows 2000, Mac OS X 10.1.5, RedHat 8.0 Linux.