Closed Bug 1599952 Opened 5 years ago Closed 5 years ago

Initialize AudioWorkletNode.port and AudioWorkletProcessor.port

Categories

(Core :: Web Audio, enhancement, P2)

Product:
Core
Component:
Web Audio
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox72 --- wontfix
firefox73 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

(Depends on 2 open bugs)

Details

Attachments

(8 files)

Bug 1599952 initialize AudioWorkletNode.port r?baku
(deleted), text/x-phabricator-request
Details
Bug 1599952 pass MessagePort to AudioWorkletGlobalScope r?baku
(deleted), text/x-phabricator-request
Details
Bug 1599952 initialize AudioWorkletProcessor.port r?baku
(deleted), text/x-phabricator-request
Details
Bug 1599952 Include chromium-config.mozbuild for dom/bindings/test
(deleted), text/x-phabricator-request
Details
Bug 1599952 Introduce UniqueMessagePortId and use it for CloneAndDisentangle() and Create() r?baku
(deleted), text/x-phabricator-request
Details
Bug 1599952 use UniqueMessagePortId in SharedWorkerManager/SharedWorkerService r?baku
(deleted), text/x-phabricator-request
Details
Bug 1599952 disable failing no-cors.https.html for unstable test names r?padenot
(deleted), text/x-phabricator-request
Details
Bug 1599952 Test processor MessagePort assignment on processor callback function construction r?bzbarsky
(deleted), text/x-phabricator-request
Details
Depends on: 1599954

as for dom/bindings.

Also, StructuredCloneHolder::CustomWriteTransferHandler() no longer appends an
unused element to mPortIdentifiers when MessagePort::CanBeCloned() returns
false.

Depends on D55212

SharedWorkerManager::MaybeCreateRemoteWorker() from
WorkerManagerCreatedRunnable didn't previously seem to ensure that
ForceClose() is called on the identifier, but RemoteWorkerController::Create()
never returns null anyway.

Depends on D55213

Keywords: leave-open

Backed out 5 changesets (bug 1599952) for failures at webaudio/the-audio-api/the-audioworklet-interface/audioworklet-messageport.https.html.ini

Backout: https://hg.mozilla.org/integration/autoland/rev/a0b1b49432603b64e3fe8798647134608ee06d77

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=78adc22d922afe2b121ff2fe848aeecdb97d8530

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279212126&repo=autoland&lineNumber=1071

Lint failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279207726&repo=autoland&lineNumber=292

[task 2019-12-03T00:30:09.803Z] 00:30:09 CRITICAL - File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/backends/static.py", line 91, in compile
[task 2019-12-03T00:30:09.803Z] 00:30:09 CRITICAL - return compile_ast(parse(stream),
[task 2019-12-03T00:30:09.803Z] 00:30:09 CRITICAL - File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/parser.py", line 787, in parse
[task 2019-12-03T00:30:09.803Z] 00:30:09 CRITICAL - return p.parse(stream)
[task 2019-12-03T00:30:09.803Z] 00:30:09 CRITICAL - File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/parser.py", line 544, in parse
[task 2019-12-03T00:30:09.804Z] 00:30:09 CRITICAL - str(e))
[task 2019-12-03T00:30:09.804Z] 00:30:09 CRITICAL - wptrunner.wptmanifest.parser.ParseError: Duplicate key expected: /builds/worker/workspace/build/tests/web-platform/meta/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-messageport.https.html.ini line 5
[task 2019-12-03T00:30:10.121Z] 00:30:10 ERROR - Return code: 1
[task 2019-12-03T00:30:10.122Z] 00:30:10 ERROR - No checks run.
[task 2019-12-03T00:30:10.122Z] 00:30:10 ERROR - No suite end message was emitted by this harness.
[task 2019-12-03T00:30:10.122Z] 00:30:10 CRITICAL - # TBPL FAILURE #

Flags: needinfo?(karlt)
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cd64849234b4 Include chromium-config.mozbuild for dom/bindings/test r=dmajor https://hg.mozilla.org/integration/autoland/rev/8e6f5cbc71f0 Introduce UniqueMessagePortId and use it for CloneAndDisentangle() and Create() r=baku https://hg.mozilla.org/integration/autoland/rev/6fbe1157d09a use UniqueMessagePortId in SharedWorkerManager/SharedWorkerService r=baku

Thanks. I don't know why lando didn't spot the merge conflicts there. https://phabricator.services.mozilla.com/D53133?vs=201307&id=201341#1689859

Flags: needinfo?(karlt)
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f2dc3d53452 initialize AudioWorkletNode.port r=baku https://hg.mozilla.org/integration/autoland/rev/1510f72d7a01 pass MessagePort to AudioWorkletGlobalScope r=baku
Pushed by shindli@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/dbf476d4eab6 Include chromium-config.mozbuild for dom/bindings/test r=dmajor https://hg.mozilla.org/mozilla-central/rev/7012927838fe Introduce UniqueMessagePortId and use it for CloneAndDisentangle() and Create() r=baku https://hg.mozilla.org/mozilla-central/rev/7768d524d914 use UniqueMessagePortId in SharedWorkerManager/SharedWorkerService r=baku https://hg.mozilla.org/mozilla-central/rev/b07c89cbc212 initialize AudioWorkletNode.port r=baku
Keywords: leave-open
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a50a90562c0d disable failing no-cors.https.html for unstable test names r=padenot https://hg.mozilla.org/integration/autoland/rev/1186352e2403 initialize AudioWorkletProcessor.port r=baku

https://hg.mozilla.org/mozilla-central/rev/a50a90562c0d
https://hg.mozilla.org/mozilla-central/rev/1186352e2403

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Attachment #9119944 - Attachment description: Bug 1565956 Test processor MessagePort assignment on processor callback function construction r?bzbarsky → Bug 1599952 Test processor MessagePort assignment on processor callback function construction r?bzbarsky
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e56cf2dc1636 Test processor MessagePort assignment on processor callback function construction r=bzbarsky
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21454 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged by moz-wptsync-bot
Regressions: 1611932
Blocks: 1473176
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: