Enable Webrender for Pixel 2/XL and Pixel 3/XL on release channel.
Categories
(Core :: Graphics: WebRender, task, P1)
Tracking
()
People
(Reporter: ktaeleman, Assigned: ktaeleman)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
Currently Webrender is enabled for Pixel 2 and Pixel 2 XL on nightly only.
To promote pixel 2 / 2 XL to release channel we need to make some code changes to
Allow webrender outside of nightly:
https://searchfox.org/mozilla-central/source/gfx/thebes/gfxPlatform.cpp#3048
and to ensure only Pixel 2 is enabled outside of nightly:
https://searchfox.org/mozilla-central/source/widget/android/GfxInfo.cpp#565
Assignee | ||
Comment 1•5 years ago
|
||
Changing bug to include enabling Pixel 3/XL as QA has done a testpass and gave green light.
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Comment on attachment 9113552 [details]
Bug 1600133 - Enable Webrender for Pixel 2/XL and Pixel 3/XL on release channel.
Beta/Release Uplift Approval Request
- User impact if declined: Webrender would not be enabled on any devices
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Medium
- Why is the change risky/not risky? (and alternatives if risky): Webrender has been enabled in Fenix Nightly for a while, but enabling it in Fenix Release could still cause issues yet unknown to us.
We will have an experiment ready to scale back webrender in case we encounter issues.
The change has been tested by QA and approved.
- String changes made/needed:
Comment 4•5 years ago
|
||
Jamie when do you expect to get to this review?
Comment 5•5 years ago
|
||
Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information
Comment 8•5 years ago
|
||
bugherder |
Comment 9•5 years ago
|
||
Comment on attachment 9113552 [details]
Bug 1600133 - Enable Webrender for Pixel 2/XL and Pixel 3/XL on release channel.
enable wr for geckoview release, approved for 72.0b7
Comment 10•5 years ago
|
||
bugherder uplift |
Description
•