Incorrect background color when using a border-radius between 0px and 1px
Categories
(Core :: Graphics: WebRender, defect, P2)
Tracking
()
People
(Reporter: mstange, Assigned: gw)
References
(Regression)
Details
(Keywords: correctness, regression)
Attachments
(2 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
Steps to reproduce:
- Enable WebRender.
- Load the attached testcase.
Expected results:
All boxes should have the same background color: full blue.
Actual results:
Some of the boxes have a lighter background, as if they were partially translucent.
|
||
Comment 1•5 years ago
|
||
mozregression --good 2019-01-01 --bad 2019-06-01 --pref gfx.webrender.all:true -a https://bug1600141.bmoattachments.org/attachment.cgi?id=9112380
9:47.53 INFO: Last good revision: d12bb5576d0f1ce9e24ff42dd567c337431504a3
9:47.53 INFO: First bad revision: cd0c67b9aeddba87b444752885396697da387620
9:47.53 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d12bb5576d0f1ce9e24ff42dd567c337431504a3&tochange=cd0c67b9aeddba87b444752885396697da387620
cd0c67b9aeddba87b444752885396697da387620 Glenn Watson — Bug 1535976 - Add a fast path for common rounded rect clips to WR. r=kvark
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
Added a patch and test case that fixes this. Try run is still pending but looks good so far.
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
||
Comment 6•5 years ago
|
||
We ship with this bug since 68, doesn't look like a good candidate for a dot release inclusion, marking as wontfix for 71.
|
||
Comment 7•5 years ago
|
||
fix-optional for 72, but feel free to request uplift if you think it's a good idea.
|
||
Comment 8•5 years ago
|
||
Verified fixed on Nightly 73.0a1 Build ID 20191205094649 on Windows 10, macOS 10.14 and Ubuntu 18.04
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 10•5 years ago
|
||
Given we are still early in the beta cycle, and the patch doesn't appear that complex, I think it is beta nomination worthy. Glenn?
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 11•5 years ago
|
||
It's a really simple patch, so should be an easy / low-risk uplift. We hadn't bothered with it because we didn't know of any real world content that was affected by it. But, feel free to create an uplift request given that we have other bugs fixed by it.
|
|
||
Comment 12•5 years ago
|
||
Comment on attachment 9112419 [details]
Bug 1600141 - Fix rounded clip rects with radii < 1px.
Beta/Release Uplift Approval Request
- User impact if declined: May see flickering with elements with border-radius > 0 and < 1 when WebRender is in use.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky):
- String changes made/needed: N/A
|
|
||
Comment 13•5 years ago
|
||
Comment on attachment 9112419 [details]
Bug 1600141 - Fix rounded clip rects with radii < 1px.
webrender fix for 72.0b5
|
|
||
Updated•5 years ago
|
|
|
||
Comment 14•5 years ago
|
||
| bugherder uplift | ||
Description
•