Remove a nested redundant #if
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Tracking
(firefox73 fixed)
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: nooffence7100, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
Filling as a good first bug to learn workflows.
XP_UNIX is checked twice and we are in the same block
https://searchfox.org/mozilla-central/source/dom/system/OSFileConstants.cpp#534
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-preprocessor.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
|
||
Comment 1•5 years ago
|
||
How do i get started. What things (tools and repositories) do i need to download?
|
Assignee | |
Comment 2•5 years ago
|
||
I will attempt to fix this bug for my university module. I will try to finish this in the next few hours.
|
Reporter | |
Comment 3•5 years ago
|
||
(In reply to abhinavk.grd from comment #1)
How do i get started. What things (tools and repositories) do i need to download?
Please read comment #0, you will find all the info that you need
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
Reporter | |
Comment 5•5 years ago
|
||
|
|
Reporter | |
Comment 8•5 years ago
|
||
(In reply to Pulsebot from comment #7)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e8ea46ef18c
excludes => exclude r=marco
My bad, sorry
|
|
Reporter | |
Updated•5 years ago
|
|
|
Reporter | |
Comment 9•5 years ago
|
||
Bravo for your patch!
|
|
Assignee | |
Comment 10•5 years ago
|
||
Thank you, great first experience!
|
||
Comment 11•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/006b8b1bb7e4
https://hg.mozilla.org/mozilla-central/rev/0e8ea46ef18c
|
||
Updated•2 years ago
|
Description
•