Closed
Bug 1600606
Opened 5 years ago
Closed 5 years ago
port changes from "Bug 1493292 - Remove aDataLen parameters from nsITransferable" and bug 1503588 to Thunderbird
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 73.0
People
(Reporter: mkmelin, Assigned: khushil324)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
nsITransferable doesn't use the length param anymore, we have some left in tb:
https://searchfox.org/comm-central/search?q=getAnyTransferData&path=
Bug 1503588 and Bug 1493292 removed them.
https://hg.mozilla.org/mozilla-central/log/tip/widget/nsITransferable.idl
- nsITransferable.setTransferData
- nsITransferable.getTransferData
- nsITranserfable.getFlavorData
- nsITransferable.getAnyTransferData
|
Reporter | |
Updated•5 years ago
|
Assignee: nobody → khushil324
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #9113588 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Updated•5 years ago
|
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 2•5 years ago
|
||
Comment on attachment 9113588 [details] [diff] [review]
Bug-1600606_remove-length-nsITransferable-0.patch
Review of attachment 9113588 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thx! r=mkmelin
::: calendar/base/content/calendar-clipboard.js
@@ +114,5 @@
>
> // Add data objects to transferable
> // Both Outlook 2000 client and Lotus Organizer use text/unicode
> // when pasting iCalendar data.
> + trans.setTransferData("text/calendar", icsWrapper); // double byte data
you can remove this comment as there's not the *2 anymore
Attachment #9113588 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Comment 3•5 years ago
|
||
Attachment #9113588 -
Attachment is obsolete: true
Attachment #9113727 -
Flags: review+
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed-tb
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ea36e46709b5
Remove length parameter from nsITransferable methods. r=mkmelin
|
||
Comment 5•5 years ago
|
||
Try to do a push after each M-C merge. You've already missed a merge today. Makes it harder to find the cause of bustages.
Target Milestone: --- → Thunderbird 73.0
You need to log in
before you can comment on or make changes to this bug.
Description
•