Closed Bug 1600652 Opened 5 years ago Closed 5 years ago

Floating text selection toolbar misplaced above the selection

Categories

(Core :: Graphics: WebRender, defect, P1)

72 Branch
Unspecified
All
defect

Tracking

()

VERIFIED FIXED
mozilla73
Tracking Status
firefox73 --- verified

People

(Reporter: ekager, Assigned: ktaeleman)

References

Details

(Whiteboard: [geckoview:m1912])

Attachments

(2 files)

Attached image toolbar.png (deleted) —

STR:

  1. Select text in Fenix/RB Nightly
  2. Floating toolbar appears way above the selected text

Looks like a recent regression in Nightly

Fenix issue: https://github.com/mozilla-mobile/fenix/issues/6877

I was able to reproduce this on github.

Priority: -- → P1
Whiteboard: [geckoview:m1912]

This only seems to happen with WebRender enabled. Can you take a look :kris?

Flags: needinfo?(ktaeleman)
Flags: needinfo?(ktaeleman)
Assignee: nobody → ktaeleman
Component: General → Graphics: WebRender
Product: GeckoView → Core

Look like the same bug was present in non-wr codepath:
https://bugzilla.mozilla.org/show_bug.cgi?id=1509271

Attachment #9117603 - Attachment is obsolete: true
Attachment #9117603 - Attachment is obsolete: false
Pushed by ktaeleman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6d89901d9bd4 Update Scroll frame metrics for android so text select popup is in correct location. r=botond
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73

Hello, I can confirm that this issue is no longer reproducible using the latest version of Firefox Preview Nightly 1/6 #200106.

Devices:

  • Nexus 5 (Android 6.0.1);
  • Nokia 6 (Android 7.1.1);
  • Google Pixel (Android 9).

Due to my findings, I'll set the status to Verified, thanks.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: