Closed Bug 1600795 Opened 5 years ago Closed 5 years ago

[jsdbg2] Debugger::wrapNullableDebuggeeObject should exist

Categories

(Core :: JavaScript Engine, enhancement, P3)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: jimb, Assigned: loganfsmyth)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1600795 - Centralize behavior for returning Debugger.Object or null. r=jimb!
(deleted), text/x-phabricator-request
Details

We have many spots in the code that look like this:

  if (!unwrapped) {
    result.set(nullptr);
    return true;
  }
  return dbg->wrapDebuggeeObject(cx, unwrapped, result);

It would be much nicer if wrapDebuggeeObject just passed through null, or if there were a variant wrapNullableDebuggeeObject that did so.

Priority: -- → P3
Assignee: nobody → loganfsmyth
Blocks: dbg-72
Pushed by loganfsmyth@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a22c83382c80 Centralize behavior for returning Debugger.Object or null. r=jimb

https://hg.mozilla.org/mozilla-central/rev/a22c83382c80

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: