nsNetworkLinkService.mm tries to read network.netlink.route.check.IPv4 preference which was removed in bug 1593693

The preferences network.netlink.route.check.IPv4 and network.netlink.route.check.IPv6 were removed in bug 1593693 and the values are now hardcoded because they are used by Linux/Android implementation of nsNetworkLinkService for link status detection and they are not supposed to be changed by the user.

https://hg.mozilla.org/mozilla-central/rev/acd8174a73b5

Michal, do we need to uplift your nsNetworkLinkService fix to 72 Beta?

Bug 1593693 removed the network.netlink.route.check.IPv4 pref in 72, which is now in Beta.

Comment on attachment 9113087 [details]
Bug 1600811 - network ID: use hardcoded IP for route checking in nsNetworkLinkService on MacOS

Beta/Release Uplift Approval Request

• User impact if declined: Less reliable network ID on Mac. VPN won't be detected.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The code from bug 1579424 was tested with the hardcoded values from this patch. This patch just fixes the problem, that the preference was removed by other bug before patch in bug 1579424 landed.
• String changes made/needed: none

Comment on attachment 9113087 [details]
Bug 1600811 - network ID: use hardcoded IP for route checking in nsNetworkLinkService on MacOS

fix network detection on osx, approved for 72.0b3

https://hg.mozilla.org/releases/mozilla-beta/rev/b88fa2f14dcb