Closed Bug 1601457 Opened 5 years ago Closed 5 years ago

ubuntu1804 - remove top menu bar from environment

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: egao, Assigned: egao)

References

Details

Attachments

(1 file, 1 obsolete file)

The top menu bar is present in GNOME desktop environment by default, and this includes the docker image used in the ubuntu1804 tests currently. An example screenshot from a failed run of mochitest-e10s-5 is attached showing this.

The current environment running ubuntu1604 has no dock or top bar, meaning the browser window can make full use of the 1600x1200 resolution.

Objectives:

  • remove the top menu bar from the docker image
Assignee: nobody → egao

I don't think we should fake an environment without the menu bar. Users will have one most of the time, except when using something else than GNOME.

I'll add that if the presence of the menu bar breaks some tests, then there's a problem with the tests, as that also means the test would fail if run locally.

The ubuntu1604 environment does not have a top bar or a dock currently.

I was not part of that setup work, so I don't know for certain, but perhaps it was removed at some point?

It was not removed. We weren't actually running the desktop environment, only the window manager. That it was not there was a side effect.

I suspect that the presence of the top menu bar is causing some issues with tests that hardcode a pixel value for the element, window size, etc.

As it stands the number of suspected failures from the presence of top menu bar is manageable, and if marionette window positioning issues can be worked out then there might be no need to remove the bar, though I'm working with a timeline of until end of December for this migration work.

Attachment #9113624 - Attachment is obsolete: true

This course of action is no longer being pursued.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: