Closed
Bug 1601685
Opened 5 years ago
Closed 4 years ago
Update BrowserTestUtils.browserLoaded code comments
Categories
(Core :: DOM: Content Processes, task, P3)
Core
DOM: Content Processes
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: u608768, Assigned: u608768)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1578465 changed the BrowserTestUtils.browserLoaded implementation, but forgot to update its comment. The following bit is no longer correct and should be updated
This is guaranteed to work because the way we're listening for the load is in the content-utils.js frame script, and then sending an async message up, so we can't miss the message.
It now uses the BrowserTestUtils JSWindowActor.
We should also add a note that says something about how calling browserLoaded without a wantLoad after multiple load operations can be racey, and that a wantLoad should be specified in these cases.
|
||
Comment 1•5 years ago
|
||
Tracking for Fission Nightly (M6)
Fission Milestone: --- → M6
Priority: -- → P3
The implementation was updated in bug 1578465, but the comment wasn't updated.
Pushed by kmadan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/895cc5d206d4
Update the BrowserTestUtils.browserLoaded() comment, r=kmag
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•