Closed
Bug 1601734
Opened 5 years ago
Closed 5 years ago
Rename AbstractScope to AbstractScopePtr
Categories
(Core :: JavaScript Engine, enhancement, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla76
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: mgaudet, Assigned: u7693, Mentored)
References
Details
(Whiteboard: [lang=c++])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
AbstractScope (to be landed in Bug 1592102) is perhaps better referred to as AbstractScopePtr because of how it's used.
|
||
Updated•5 years ago
|
Priority: -- → P2
|
Reporter | |
Comment 1•5 years ago
|
||
Prerequisites
Before getting started, you'll want to
- You Have a checkout of the Firefox source code
- Make sure you can build SpiderMonkey
- Understand the basics of using Mercurial
- Understand how to submit a patch
- Read this walkthrough about how development works in Firefox
Success Criteria
- The type
AbstractScopehas been renamed toAbstractScopePtr. - After this rename, the engine compiles, and passes the tests (run
../jit-test/jit_test.py ./dist/bin/jsfrom your build directory)
Questions
If you have questions, feel free to visit us on in the Spidermonkey room on Matrix, or post questions here.
Mentor: mgaudet
Whiteboard: [lang=c++]
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → u7693
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
||
Updated•5 years ago
|
Attachment #9132467 -
Attachment is obsolete: true
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5af318a2b56
Rename AbstractScope to AbstractScopePtr r=mgaudet
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•