Closed Bug 1601774 Opened 5 years ago Closed 1 year ago

In Discovery Stream, use fluent term for Recommended by Pocket

Categories

(Firefox :: New Tab Page, enhancement, P2)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: thecount, Assigned: thecount)

Details

Right now the Recommended by Pocket is using a variable passed in.

Looks like we have access to term for brands within mozilla, including Pocket.

This is currently how we do "What's Pocket"

newtab-pocket-whats-pocket = What’s { -pocket-brand-name }?

Assignee: nobody → sdowne
Priority: -- → P2
No longer blocks: pocket-newtab
Severity: normal → S3

Looked into this. At a glance it looked wrong, but looking closer, the variable name is kinda doing the right thing.

The "Recommended by Pocket" section is still setup to be configured to be recommended by other providers, so we shouldn't be hard coding -pocket-brand-name in this particular string.

So while that's still the case, it's probably not worth fixing this.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.