Add page orientation parameter to snippets preview
Categories
(Firefox :: Messaging System, defect, P1)
Tracking
()
People
(Reporter: giorgos, Assigned: emcminn)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
We want Arabic to display correctly in all Snippet Templates. Prioritize the Simple Snippet and the Simple Snippet Bellow Search bar templates if you tackle each one separately.
Thanks!
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Confirmed that this is in fact an issue with the preview feature.
The fix we agreed on was to add a new query parameter similar to how theme
works and would flip the page to RTL mode.
This parameter will be used by the snippets preview tool to select the correct layout.
Assignee | ||
Comment 2•5 years ago
|
||
The URLSearchParams now has a property "dir", which can be set to "rtl" to preview right-to-left orientation
Updated•5 years ago
|
Comment 3•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emcminn, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 4•5 years ago
|
||
@andreio, would you be able to land this for me? No rush :)
Updated•5 years ago
|
Comment 6•5 years ago
|
||
bugherder |
Comment 7•5 years ago
|
||
Does this need Beta uplift or can it ride Fx74 to release?
Assignee | ||
Comment 8•5 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)
Does this need Beta uplift or can it ride Fx74 to release?
My impression is that since it only affects the preview feature (not anything user-facing), it's okay for it to ride the trains. :)
Updated•5 years ago
|
Comment 9•5 years ago
|
||
I have verified that this issue is no longer reproducible with the latest Firefox Nightly (74.0a1 Build ID - 20200205055433) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.2. Now, the below search bar snippet respects the page orientation.
In order to verify this issue I've used the following steps:
- Create the
browser.newtab.activity-stream.asrouter.whitelistHosts
pref with the["gist.githubusercontent.com"]
value in the "about:config" page. - Switch the
browser.newtabpage.activity-stream.feeds.asrouterfeed
pref's value tofalse
and back totrue
. - Navigate to about:newtab?endpoint=https://gist.githubusercontent.com/piatra/3029b3336c2df8f64ebb72ca3e027bae/raw/503c53e41a748fd6d1b2be1cd11e45e8c2e49e1b/endpoint.json&dir=rtl .
Description
•