Closed Bug 1601912 Opened 5 years ago Closed 5 years ago

Late Beta: /security/certverifier/NSSCertDBTrustDomain.h error: private field 'mCRLiteMode' is not used

Categories

(Core :: Security: PSM, defect, P1)

Product:
Core
Component:
Security: PSM
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla73
Project Flags:
Root Cause Coding: Syntax Error
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox71 --- unaffected
firefox72 --- unaffected
firefox73 blocking verified

People

(Reporter: RaulG, Assigned: keeler)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [psm-assigned])

Attachments

(1 file)

bug 1601912 - "use" CRLite fields in NSSCertDBTrustDomain to silence compiler warnings r?jcj
(deleted), text/x-phabricator-request
Details

[Tracking Requested - why for this release]:

Central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=279985054&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=08f59f03a37a00442b2d9ec35619e93a24907b12

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279985054&repo=try&lineNumber=21726

Log snippet:

[task 2019-12-06T10:25:40.555Z] 10:25:40 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/threads'
[task 2019-12-06T10:25:40.676Z] 10:25:40 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/security/certverifier'
[task 2019-12-06T10:25:40.680Z] 10:25:40 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -m32 -o Unified_cpp_certverifier0.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/security/certverifier -I/builds/worker/workspace/build/src/obj-firefox/security/certverifier -I/builds/worker/workspace/build/src/security/ct -I/builds/worker/workspace/build/src/security/manager/ssl -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wextra -Wunreachable-code -Wno-unused-parameter -MD -MP -MF .deps/Unified_cpp_certverifier0.o.pp Unified_cpp_certverifier0.cpp
[task 2019-12-06T10:25:40.680Z] 10:25:40 INFO - In file included from Unified_cpp_certverifier0.cpp:11:
[task 2019-12-06T10:25:40.680Z] 10:25:40 INFO - In file included from /builds/worker/workspace/build/src/security/certverifier/CertVerifier.cpp:16:
[task 2019-12-06T10:25:40.680Z] 10:25:40 ERROR - /builds/worker/workspace/build/src/security/certverifier/NSSCertDBTrustDomain.h:290:14: error: private field 'mCRLiteMode' is not used [-Werror,-Wunused-private-field]
[task 2019-12-06T10:25:40.680Z] 10:25:40 INFO - CRLiteMode mCRLiteMode;
[task 2019-12-06T10:25:40.680Z] 10:25:40 INFO - ^
[task 2019-12-06T10:25:40.680Z] 10:25:40 ERROR - /builds/worker/workspace/build/src/security/certverifier/NSSCertDBTrustDomain.h:299:24: error: private field 'mCRLiteTelemetryInfo' is not used [-Werror,-Wunused-private-field]
[task 2019-12-06T10:25:40.680Z] 10:25:40 INFO - CRLiteTelemetryInfo* mCRLiteTelemetryInfo;
[task 2019-12-06T10:25:40.680Z] 10:25:40 INFO - ^
[task 2019-12-06T10:25:40.680Z] 10:25:40 INFO - 2 errors generated.
[task 2019-12-06T10:25:40.680Z] 10:25:40 INFO - /builds/worker/workspace/build/src/config/rules.mk:804: recipe for target 'Unified_cpp_certverifier0.o' failed
[task 2019-12-06T10:25:40.680Z] 10:25:40 ERROR - make[4]: *** [Unified_cpp_certverifier0.o] Error 1
[task 2019-12-06T10:25:40.680Z] 10:25:40 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/security/certverifier'
[task 2019-12-06T10:25:40.680Z] 10:25:40 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'security/certverifier/target-objects' failed
[task 2019-12-06T10:25:40.680Z] 10:25:40 ERROR - make[3]: *** [security/certverifier/target-objects] Error 2
[task 2019-12-06T10:25:40.680Z] 10:25:40 INFO - make[3]: *** Waiting for unfinished jobs....
[task 2019-12-06T10:25:40.682Z] 10:25:40 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/threads'
[task 2019-12-06T10:25:40.682Z] 10:25:40 INFO - xpcom/threads/ThreadDelay.o
[task 2019-12-06T10:25:40.682Z] 10:25:40 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/threads'
[task 2019-12-06T10:25:40.899Z] 10:25:40 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/threads'
[task 2019-12-06T10:25:40.904Z] 10:25:40 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -m32 -o ThreadDelay.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/xpcom/threads -I/builds/worker/workspace/build/src/obj-firefox/xpcom/threads -I/builds/worker/workspace/build/src/xpcom/build -I/builds/worker/workspace/build/src/caps -I/builds/worker/workspace/build/src/tools/profiler -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -MD -MP -MF .deps/ThreadDelay.o.pp /builds/worker/workspace/build/src/xpcom/threads/ThreadDelay.cpp
[task 2019-12-06T10:25:40.904Z] 10:25:40 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/threads'

Flags: needinfo?(dkeeler)
Summary: /security/certverifier/NSSCertDBTrustDomain.h error: private field 'mCRLiteMode' is not used → Late Beta: /security/certverifier/NSSCertDBTrustDomain.h error: private field 'mCRLiteMode' is not used
Assignee: nobody → dkeeler
Flags: needinfo?(dkeeler)
Priority: -- → P1
Whiteboard: [psm-assigned]

When cert_storage is disabled, the CRLite mode and telemetry fields don't get
used by NSSCertDBTrustDomain, so we get warnings-as-errors about unused fields.
This uses Unused to silence the warnings.

This also adds a missing #include to CertBlocklist.cpp.

Pushed by ccoroiu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d646a22e7876 "use" CRLite fields in NSSCertDBTrustDomain to silence compiler warnings r=jcj

https://hg.mozilla.org/mozilla-central/rev/d646a22e7876

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Severity: normal → critical
tracking-firefox73: ? → blocking

Verified as fixed with this beta sim:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=ff0e0b512d0ffa76b274aaa6abdb2237728113de

Ryan, this is verified as fixed, should we change the severity and tracking flag?

Status: RESOLVED → VERIFIED
status-firefox73: fixed → verified
Flags: needinfo?(ryanvm)

No.

Flags: needinfo?(ryanvm)

Please specify a root cause for this bug. See :tmaity for more information.

Root Cause: --- → ?
Root Cause: ? → Coding: Syntax Error
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: