Closed Bug 1601966 Opened 5 years ago Closed 4 years ago

widget.wayland_vsync.enabled not applied to auto scroll at about:support

Categories

(Core :: Widget: Gtk, defect, P3)

73 Branch
defect

Tracking

()

RESOLVED DUPLICATE of bug 1645528

People

(Reporter: tempel.julian, Unassigned)

References

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

Enable auto scroll, widget.wayland_vsync.enabled, restart and open about:support inside a Sway Wayland session.

Actual results:

Auto scroll happens at fixed 60fps, instead of running at proper vsync like 75fps @ 75Hz.

Expected results:

It should run at proper vsync, like mouse wheel scrolling and keyboard button scrolling do (the latter at least on that particular site).

Hi walmartguy,

Thanks for reporting this bug.

Unfortunately, I don't have the proper configuration to test it on my end, but as a starting point, I'll add a product and component to this bug.

In the meantime, can you please confirm the following?

Regards,
Virginia

Component: Untriaged → Widget: Gtk
Product: Firefox → Core

Yes, happens also with Nightly 73a1 2019-12-10 and fresh profile.

Kenny, any idea here?
Thanks.

Flags: needinfo?(bugzilla)
Priority: -- → P3

I believe the cause would be that autoscroll movement runs off the synthetic global VsyncSource, rather than the new widget-local one. This would make it appear choppy, even though composition is still running smooth off vsync.

I'd have to look at where autoscroll is scheduled to say anything conclusive, though.

Flags: needinfo?(bugzilla)
Blocks: 1629140

Likely a duplicate of bug 1645528, but haven't tested yet.

Julian, could you confirm that this is fixed in the latest nightlies?

Flags: needinfo?(tempel.julian)

Yes, it is fixed. I've also noticed that vsynctester.com animation is smoothly vsynced, as is WebGL. Terrific work!

Flags: needinfo?(tempel.julian)

Great, thank you :)

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE

Hi,
I'm just wondering if this will be back-ported to the ESR version. Right now the nightly is working as expected for me, while firefox-78.7.1-esr on gentoo still doesn't display the widget. It's not a huge deal not to have a widget display, but it would be preferable. Thank you all for all of your work :)

You need to log in before you can comment on or make changes to this bug.