Report CheckMayLoad errors to the web console, not just the browser console
Categories
(Core :: DOM: Security, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [domsecurity-active])
Attachments
(2 files)
Right now CheckMayLoad errors don't get reported to the browser console, because they have no window id associated with them. We should fix that.
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
This will allow the errors reported via this method to show up in the web console as needed.
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
CheckMayLoadAndReport takes a window ID. This allows us to report
errors from it to the web console as needed. Most consumers know statically
whether they want reporting or not, so there's no reason to force the ones that
don't to provide window ids.
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Comment 4•5 years ago
|
||
Backed out 4 changesets (bug 1602483, bug 1602090) for causing perma leackchecks
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=e3e2c1d7478e450e2b32c85c416ccf70f9de56d3&selectedJob=280891198
backout: https://hg.mozilla.org/integration/autoland/rev/3bc1b1922126f73bb25b0b1ae0d6dab7e164116d
|
|
Assignee | |
Comment 5•5 years ago
|
||
We hit a pre-existing leak in the devtools code. Bug 1603666 is tracking fixing that.
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a7116fcfcd8f
https://hg.mozilla.org/mozilla-central/rev/f6b36c3a329b
Description
•