Closed
Bug 1602222
Opened 5 years ago
Closed 5 years ago
Use consistent definition of JSScript::IsModule / LazyScript::IsModule
Categories
(Core :: JavaScript Engine, task, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(2 files)
LazyScript::isModule is true for all inner functions of a module, while JSScript only sets it for the top-level. This needs to be fixed for Bug 1529456.
|
Assignee | |
Comment 1•5 years ago
|
||
The fix here might be add a flag to the scriptSource to cover all-scripts-within-a-module.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Lazy scripts were using the IsModule flag with different semantics than
compiled scripts and so this patch adds a new flag instead. The flag is
initialized from non-lazy scripts for consistency.
|
||
Updated•5 years ago
|
Assignee: nobody → tcampbell
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D57220
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42f003a50150
Add HasModuleGoal flag to js::BaseScript. r=jandem
https://hg.mozilla.org/integration/autoland/rev/887237f5f3e0
Move LazyScript::parseGoal() to BaseScript. r=jandem
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/42f003a50150
https://hg.mozilla.org/mozilla-central/rev/887237f5f3e0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•