Open Bug 1602303 Opened 5 years ago Updated 2 years ago

Make urlbar's search-glass open search suggestions

Categories

(Firefox :: Address Bar, enhancement, P5)

71 Branch
enhancement

Tracking

()

People

(Reporter: mvocom, Unassigned)

References

(Blocks 1 open bug)

Details

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

Set .urlbarView to show search suggestions only.
Type Firefox in the urlbar.
Move focus to another element.

Actual results:

The only way to open .urlbarView with the search suggestions is typing in the urlbar (e.g. a space).

Expected results:

An option to open the search suggestions as it works in the searchbar.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Address Bar

(In reply to Yaron from comment #0)

Set .urlbarView to show search suggestions only.

How?

The only way to open .urlbarView with the search suggestions is typing in the urlbar (e.g. a space).

Or focus the urlbar again?

I don't understand your bug report, I'm sorry. Which use-case are you covering? What's the intent of the change?
Please post more details.

Flags: needinfo?(mvocom)

(In reply to Marco Bonardo [:mak] from comment #2)

(In reply to Yaron from comment #0)

Set .urlbarView to show search suggestions only.

How?

Preferences -> Privacy and Security -> Address Bar.
Uncheck History, Bookmarks and Opened Tabs.

Preferences ->Search -> Search Suggestuon.
Check "Show Search Suggestion", and "Show Search Suggestion in the Address Bar Results".

The only way to open .urlbarView with the search suggestions is typing in the urlbar (e.g. a space).

Or focus the urlbar again?

Unlike the Search Bar, re-focusing the URL Bar does NOT open the suggestions.

Flags: needinfo?(mvocom)

Ok, now I understand, I think the new design we are working on is resolving this.

Status: UNCONFIRMED → NEW
Depends on: urlbar-update-1
Ever confirmed: true
Priority: -- → P5

Thank you Marco.

@Marco,

I've just enabled "browser.urlbar.update1" in FF 72.
It looks great. Thank you.

I understand this is still WIP.
Still, some comments:

Re-focusing the URL Bar opens the suggestions most of the times (there are some glitches here and there).
Switching to another tab and returning to the previous tab - re-focusing the URL Bar does not open the suggestions.

Enlarging the height and width on focus is not visually appealing to say the least.
I can change that with CSS but I really don't see the advantage in the default design.

In a private window, hovering over the suggestions - a "Mozilla Firefox (Private Browsing)" tooltip shows up.
This is not helpful but rather distracting and confusing IMO.

(In reply to Yaron from comment #6)

Re-focusing the URL Bar opens the suggestions most of the times (there are some glitches here and there).
Switching to another tab and returning to the previous tab - re-focusing the URL Bar does not open the suggestions.

Enlarging the height and width on focus is not visually appealing to say the least.
I can change that with CSS but I really don't see the advantage in the default design.

Thank you for your feedback, there are still a few bugs in the reopening that I'm addressing in bug 1601052.
The expansion was an explicit request of User Experience, it has its own reasons and I'm not the best person to evaluate those.
Note however that update1 is not stable yet, we're working on it, so Firefox 72 could provide a non optimal experience.

In a private window, hovering over the suggestions - a "Mozilla Firefox (Private Browsing)" tooltip shows up.
This is not helpful but rather distracting and confusing IMO.

Can you please be more specific about what you are pointing at, or maybe attach a screenshot?

Flags: needinfo?(mvocom)

(In reply to Marco Bonardo [:mak] from comment #7)

Thank you for replying and the ongoing work. I appreciate it.

The expansion was an explicit request of User Experience, it has its own reasons and I'm not the best person to evaluate those.

I assume I'm not the only one who doesn't like this design. I hope "User Experience" gets the feedback. :)

In a private window, hovering over the suggestions - a "Mozilla Firefox (Private Browsing)" tooltip shows up.
This is not helpful but rather distracting and confusing IMO.

Can you please be more specific about what you are pointing at, or maybe attach a screenshot?

https://i.postimg.cc/gJ9cwcPr/PB.png

Hover with the mouse over any suggestion and the tooltip will show up.

Flags: needinfo?(mvocom)
Blocks: 1603165
No longer depends on: urlbar-update-1
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.