Closed Bug 1602380 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 20674 - testdriver.js: Make set_permission() take a PermissionDescriptor, not a name

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 20674 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20674
Details from upstream follow.

Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> wrote:

testdriver.js: Make set_permission() take a PermissionDescriptor, not a name

Making the public API take a permission name only works for permissions that
take a PermissionDescriptor, and makes it impossible to set permissions
that require extra information (i.e. they take a MidiPermissionDescriptor
or a PushPermissionDescriptor instead).

Instead of taking a string corresponding to a permission name, take a
PermissionDescriptor directly so that all required information can be
specified.

While here, make set_permission.html an HTTPS test, as some permissions
are only available in a secure context (such as "push", which is being used
to test setting a permission that requires extra parameters in the
descriptor).

Fixes #20672.

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Test result changes from PR not available.
Attached file Notable wpt changes (deleted) —
# CI Results Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 404 tests and 1 subtests ## Status Summary ### Firefox OK : 297[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview']] 301[[u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt']] 307[['GitHub']] PASS : 259[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview']] 260[['GitHub']] 291[[u'Gecko-linux64-debug', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt']] 292[[u'Gecko-linux64-opt']] 293[[u'Gecko-linux64-asan-opt']] FAIL : 507[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview']] 514[[u'Gecko-linux64-asan-opt']] 515[[u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug']] 516[[u'Gecko-linux64-debug', u'Gecko-linux64-qr-opt']] 547[['GitHub']] PRECONDITION_FAILED: 3 TIMEOUT : 38[[u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt']] 47[['GitHub']] 49[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview']] ERROR : 78[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview']] 80[[u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt']] 82[['GitHub']] NOTRUN : 21[[u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt']] 22[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview']] 51[['GitHub']] ### Chrome OK : 373 PASS : 2686 FAIL : 276 PRECONDITION_FAILED: 3 TIMEOUT : 49 ERROR : 9 NOTRUN : 93 ### Safari OK : 244 PASS : 179 FAIL : 319 PRECONDITION_FAILED: 3 TIMEOUT : 163 ERROR : 69 NOTRUN : 174 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=d19c94d60e12eac241fb9b1522ca8a73e18a72d4) [GitHub PR Head](https://wpt.fyi/results/?sha=5cb79c7f0f568fb258ad39219cbedb9da947767b&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=5cb79c7f0f568fb258ad39219cbedb9da947767b&label=pr_base) ## Details ### Firefox-only Failures /shadow-dom/focus/focus-tabindex-order-shadow-zero-host-negative.html Order when all tabindex=0 except for host, which has tabindex=-1: FAIL /shadow-dom/focus/focus-tabindex-order-shadow-zero-delegatesFocus.html Order when all tabindex=0 is and delegatesFocus = true: FAIL /pointerevents/pointerevent_setpointercapture_invalid_pointerid.html setPointerCapture: DOMException NotFoundError: FAIL /shadow-dom/focus/focus-tabindex-order-shadow-zero-host-one.html Order when all tabindex=0 except for host, which has tabindex=1: FAIL /shadow-dom/focus/focus-tabindex-order-shadow-varying-delegatesFocus.html Order when tabindex varies and delegatesFocus = true: FAIL /payment-request/payment-request-canmakepayment-method.https.html All methods are unsupported: FAIL /reporting/order.html: ERROR /payment-request/payment-request-canmakepayment-method-protection.https.html Optionally, at the user agent's discretion, return a promise rejected with a "NotAllowedError" DOMException.: FAIL /pointerevents/pointerlock/pointerevent_movementxy.html: ERROR /pointerevents/pointerevent_pointerenter_does_not_bubble.html mouse pointerenter.fromElement value is null.: FAIL mouse pointerenter.toElement attribute exists: FAIL mouse pointerenter.fromElement attribute exists: FAIL mouse pointerenter.toElement value is null.: FAIL /shadow-dom/focus/click-focus-delegatesFocus-tabindex-zero.html click on host with delegatesFocus, all tabindex=0 except spacer: FAIL /reporting/nestedReport.html: ERROR /shadow-dom/focus/focus-tabindex-order-shadow-negative-delegatesFocus.html Order when all tabindex=-1 is and delegatesFocus = true: FAIL /shadow-dom/focus/focus-method-delegatesFocus.html focus() on host with delegatesFocus with another host with no delegatesFocus and a focusable child: FAIL focus() on host with delegatesFocus with another host with delegatesFocus and a focusable child: FAIL focus() on host with delegatesFocus & tabindex=0, #outside with tabindex=0: FAIL focus() on host with delegatesFocus & tabindex=0, #aboveSlots and #belowSlots with tabindex=0: FAIL focus() on host with delegatesFocus, all tabindex=0: FAIL focus() on host with delegatesFocus & tabindex=0, #slottedToFirstSlot, #slottedToSecondSlot, #belowSlots with tabindex=0: FAIL focus() on host with delegatesFocus & tabindex=0, #belowSlots with tabindex=0: FAIL focus() on host with delegatesFocus & tabindex =-1, all other tabindex=0: FAIL focus() on host with delegatesFocus & no tabindex, all other tabindex=0: FAIL /reporting/generateTestReport.html: ERROR /layout-instability/observe-layout-shift.html: TIMEOUT /input-events/input-events-typing.html InputEvent have correct data/order when typing on textarea and contenteditable: FAIL /pointerevents/pointerevent_releasepointercapture_invalid_pointerid.html releasePointerCapture: DOMException NotFoundError: FAIL /shadow-dom/focus/focus-selector-delegatesFocus.html :focus applies to host with delegatesFocus=true when the shadow root's descendant has focus: FAIL :focus applies to host with delegatesFocus=true when an element in a nested shadow tree with delegatesFocus=true is focused: FAIL /pointerevents/pointerevent_pointerleave_does_not_bubble.html mouse pointerleave.toElement value is null.: FAIL mouse pointerleave.fromElement value is null.: FAIL mouse pointerleave.toElement attribute exists: FAIL mouse pointerleave.fromElement attribute exists: FAIL (See attachment for full changes)
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: