[wpt-sync] Sync PR 20674 - testdriver.js: Make set_permission() take a PermissionDescriptor, not a name
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox73 fixed)
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Attachments
(1 file)
(deleted),
text/plain
|
Details |
Sync web-platform-tests PR 20674 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/20674
Details from upstream follow.
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> wrote:
testdriver.js: Make set_permission() take a PermissionDescriptor, not a name
Making the public API take a permission name only works for permissions that
take aPermissionDescriptor
, and makes it impossible to set permissions
that require extra information (i.e. they take aMidiPermissionDescriptor
or aPushPermissionDescriptor
instead).Instead of taking a string corresponding to a permission name, take a
PermissionDescriptor
directly so that all required information can be
specified.While here, make
set_permission.html
an HTTPS test, as some permissions
are only available in a secure context (such as "push", which is being used
to test setting a permission that requires extra parameters in the
descriptor).Fixes #20672.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0cd36506960e
https://hg.mozilla.org/mozilla-central/rev/a343ec3a2672
Description
•