Remove xpidl [array] use in calIRecurrenceInfo.idl
Categories
(Calendar :: General, task)
Tracking
(Not tracked)
People
(Reporter: khushil324, Assigned: benc)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
darktrojan
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•5 years ago
|
||
Try run covering all the calendar recurrence patches:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a8b670ba0bb1717ad6a4bc8ca55b0305df4bcd84
|
||
Comment 2•5 years ago
|
||
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
The problem was in the calIRecurranceItem changes in Bug 1602424, addressed over there in a new patch.
No changes needed here.
Again, covered by this try build:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=5cb6d13351199bb8ebbf8a7c2befc2d5c997a16a
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 4•5 years ago
|
||
|
|
||
Updated•5 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d0bcd93317f9
Remove xpidl [array] use in calIRecurrenceInfo. r=darktrojan
|
|
||
Updated•5 years ago
|
|
||
Comment 7•5 years ago
|
||
Would you mind putting the DONTBUILD into the commit message line. Like this, it's clearly visible without having to open the changeset.
|
|
||
Comment 8•5 years ago
|
||
Why do you want to see it?
|
|
||
Comment 9•5 years ago
|
||
So I don't have have to scratch my head wondering why certain jobs didn't run. I'm not sure why you are lobbying "Magnus-only" rules here when the rest of the project and all of Mozilla put it onto the first line.
|
|
||
Comment 10•5 years ago
|
||
I'm not lobbying any rules, and am unaware of any rules in this regard. I just had a good reason to put it there in this bug: the job should run, just that the nightly cron job was going to take care of it anyway minutes later.
|
|
||
Comment 11•5 years ago
|
||
Sure, if we land stuff just before the Daily run, we typically land with DONTBUILD if it's a small change. But the DONTBUILD goes onto the same line as the commit message. That's how we've always done it and that's how Mozilla do it. On the tree you can hover the shortened line and it will show it to you completely in the tooltip.
Description
•