Closed Bug 1602427 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 20679 - [css-pseudo] Fix WPT test mismatch expectations for ::marker

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Product:
Core
Component:
Layout: Generated Content, Lists, and Counters
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20679 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20679
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-pseudo] Fix WPT test mismatch expectations for ::marker

In some tests I added both "match" and "mismatch" conditions, expecting
both of them to hold since that's how Chromium treats that.

However, according to the docs, if a test has multiple conditions, they
should be treated as an OR operator. This makes a test pass in Firefox
even if the rendering is wrong. The proper way to check multiple
conditions with the AND operator is adding the extra ones in the
references.

Spec: https://web-platform-tests.org/writing-tests/reftests.html#complex-pass-conditions
Change-Id: Idb737e2486f2155f05a09a2c88bc1094c1b603e2
Reviewed-on: https://chromium-review.googlesource.com/1958128
WPT-Export-Revision: 7b6277dd8465d0915f82b20beee9d36a7eed2c42

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core
Test result changes from PR not available.

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 1[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview']] 2[[u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt', u'Gecko-windows10-64-debug', u'Gecko-windows10-64-opt', u'Gecko-windows10-64-qr-debug', u'Gecko-windows10-64-qr-opt', u'Gecko-windows7-32-debug', u'Gecko-windows7-32-opt', 'GitHub']]
FAIL: 2[[u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt', u'Gecko-windows10-64-debug', u'Gecko-windows10-64-opt', u'Gecko-windows10-64-qr-debug', u'Gecko-windows10-64-qr-opt', u'Gecko-windows7-32-debug', u'Gecko-windows7-32-opt', 'GitHub']] 3[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview']]

Chrome

FAIL: 4

Safari

FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/marker-font-variant-numeric-normal.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/marker-unicode-bidi-default.html: FAIL[Gecko-android-em-7.0-x86_64-debug-geckoview,Gecko-android-em-7.0-x86_64-opt-geckoview], PASS[Gecko-linux64-asan-opt,Gecko-linux64-debug,Gecko-linux64-opt,Gecko-linux64-qr-debug,Gecko-linux64-qr-opt,Gecko-windows10-64-debug,Gecko-windows10-64-opt,Gecko-windows10-64-qr-debug,Gecko-windows10-64-qr-opt,Gecko-windows7-32-debug,Gecko-windows7-32-opt,GitHub] (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/marker-unicode-bidi-normal.html: FAIL (Chrome: FAIL, Safari: FAIL)

https://hg.mozilla.org/mozilla-central/rev/1e03af3235b6
https://hg.mozilla.org/mozilla-central/rev/ff879187b452

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.